Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "fix: respect default detection depth of 4" #5549

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Revert "fix: respect default detection depth of 4" #5549

merged 1 commit into from
Oct 23, 2024

Conversation

thisislawatts
Copy link
Member

@thisislawatts thisislawatts commented Oct 23, 2024 •
edited
Loading

This reverts commit 45a74ea.

After some internal discussion we have decided to continue with the detection-dept defaulting to no limit. This behaviour brings alignment with defaults for our snyk iac test command and improves the coverage for our customers.

Pull Request Submission Checklist

  • Follows CONTRIBUTING guidelines
  • Includes detailed description of changes
  • Contains risk assessment (Low | Medium | High)
  • Highlights breaking API changes (if applicable)
  • Links to automated tests covering new functionality
  • Includes manual testing instructions (if necessary)
  • Updates relevant GitBook documentation (PR link: ___)

What does this PR do?

Where should the reviewer start?

How should this be manually tested?

@github-actions GitHub Actions
Copy link
Contributor

Warnings
⚠️

Since the CLI is unifying on a standard and improved tooling, we're starting to migrate old-style imports and exports to ES6 ones.
A file you've modified is using either module.exports or require(). If you can, please update them to ES6 import syntax and export syntax.
Files found:

  • src/lib/plugins/get-deps-from-plugin.ts

Generated by 🚫 dangerJS against e024276

@thisislawatts thisislawatts marked this pull request as ready for review October 23, 2024 14:09
@thisislawatts thisislawatts requested a review from a team as a code owner October 23, 2024 14:09
@thisislawatts thisislawatts merged commit 20cedcf into release-candidate Oct 23, 2024
5 checks passed
@thisislawatts thisislawatts deleted the fix/revert-detection-depth branch October 23, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j-luong j-luong j-luong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thisislawatts @j-luong